Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PageHeader Tabs margin bottom #25340

Merged
merged 1 commit into from Jul 1, 2020
Merged

Conversation

dickeylth
Copy link
Contributor

@dickeylth dickeylth commented Jul 1, 2020

fixes issue: ant-design/ant-design-pro#6906

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close ant-design/ant-design-pro#6906

💡 Background and solution

Tablist in antd pro page header has unnecessary bottom margin.

📝 Changelog

Language Changelog
🇺🇸 English Fix PageHeader Tabs unnecessary margin-bottom.
🇨🇳 Chinese 修复 PageHeader 内 Tabs 不必要的 margin-bottom

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 1, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 1, 2020

@afc163 afc163 changed the title fix:tabList bottom margin in page header fix: PageHeader Tabs margin bottom Jul 1, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cf7f442:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #25340 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25340   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         368      368           
  Lines        7290     7290           
  Branches     2044     1995   -49     
=======================================
  Hits         7255     7255           
  Misses         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9231a...cf7f442. Read the comment docs.

@afc163 afc163 merged commit 0a80ca7 into ant-design:master Jul 1, 2020
27 checks passed
@afc163 afc163 mentioned this pull request Jul 6, 2020
13 tasks
@zombieJ zombieJ mentioned this pull request Jul 6, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants