fix: change progress to percent in success props & warning in Progress #25356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这个地方之前写错 devWarnning 的条件了😅 |
|
那个 api 如果也要调整的话，应该放在feature分支还是？ |
|
|
|
|
|
顺便把
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5bfd314:
|
Codecov Report
@@ Coverage Diff @@
## master #25356 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 368 368
Lines 7292 7303 +11
Branches 2042 2049 +7
=======================================
+ Hits 7255 7266 +11
Misses 37 37
Continue to review full report at Codecov.
|
|
changelog 写一下。 |
fireairforce
changed the title
afc163
reviewed
Jul 1, 2020
| <div | ||
| class="ant-progress-success-bg" | ||
| style="width: 30%; height: 8px; background-color: rgb(255, 255, 255);" | ||
| /> |
This comment has been minimized.
This comment has been minimized.
|
还得补下测试。。。QuQ |
afc163
reviewed
Jul 1, 2020
| <Progress percent={60} success={{ progress: 30 }} />, | ||
| ); | ||
| expect(errorSpy).toHaveBeenCalledWith( | ||
| 'Warning: [antd: Progress] `progress` is deprecated. Please use `percent` instead.', |
There was a problem hiding this comment.
Suggested change
| 'Warning: [antd: Progress] `progress` is deprecated. Please use `percent` instead.', | |
| 'Warning: [antd: Progress] `success.progress` is deprecated. Please use `success.percent` instead.', |
This was referenced Jul 3, 2020
|
如何让这个警告消失，我用了customRequest |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close: #25353
💡 Background and solution
📝 Changelog
success.progresstosuccess.percent.success.progress为success.percent。☑️ Self Check before Merge