Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve nb_NO translations #25374

Merged
merged 5 commits into from Jul 6, 2020
Merged

feat: improve nb_NO translations #25374

merged 5 commits into from Jul 6, 2020

Conversation

Johannes-Andersen
Copy link
Contributor

@Johannes-Andersen Johannes-Andersen commented Jul 1, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other: Localization improvements

🔗 Related issue link

No tickets

💡 Background and solution

There was a huge lack of translations for nb_NO. I have updated some mistakes from rc-pagination and added translations values from en_US to the NO templates where missing

📝 Changelog

Language Changelog
🇺🇸 English 🇳🇴 Added missing nb_NO translations
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@Johannes-Andersen
Copy link
Contributor Author

Johannes-Andersen commented Jul 1, 2020

This is my first pull request. So feel free to be as be critical and let me know if there is something wrong or something else needed/missing.

Thanks,
Johannes

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 1, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 1, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5475624:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #25374 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25374      +/-   ##
==========================================
- Coverage   99.50%   99.49%   -0.02%     
==========================================
  Files         368      368              
  Lines        7300     7304       +4     
  Branches     1999     2000       +1     
==========================================
+ Hits         7264     7267       +3     
- Misses         36       37       +1     
Impacted Files Coverage Δ
components/date-picker/locale/nb_NO.tsx 100.00% <ø> (ø)
components/time-picker/locale/nb_NO.tsx 100.00% <ø> (ø)
components/locale/nb_NO.tsx 100.00% <100.00%> (ø)
components/_util/responsiveObserve.ts 97.29% <0.00%> (-2.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 645bbac...5475624. Read the comment docs.

@yoyo837 yoyo837 changed the title feat: improve nb_NO translations [WIP]feat: improve nb_NO translations Jul 3, 2020
@pr-triage pr-triage bot removed the PR: unreviewed label Jul 3, 2020
@Johannes-Andersen Johannes-Andersen changed the title [WIP]feat: improve nb_NO translations feat: improve nb_NO translations Jul 5, 2020
@Johannes-Andersen Johannes-Andersen requested a review from yoyo837 Jul 5, 2020
@afc163 afc163 merged commit f71d2d5 into ant-design:master Jul 6, 2020
25 checks passed
@afc163 afc163 mentioned this pull request Jul 6, 2020
13 tasks
@zombieJ zombieJ mentioned this pull request Jul 6, 2020
13 tasks
biuge pushed a commit to biuge/ant-design that referenced this issue Dec 30, 2020
* feat: improve nb_NO translations

* fix: issued with VSCode not highlighting issues

* fix: fix failing snapshot test

* Updated rc-picker 1.10.0 -> 1.10.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants