Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat message hooks #25422

Merged
merged 22 commits into from Jul 15, 2020
Merged

Feat message hooks #25422

merged 22 commits into from Jul 15, 2020

Conversation

07akioni
Copy link
Contributor

@07akioni 07akioni commented Jul 3, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Add useMessage hook for Message to support context access.
🇨🇳 Chinese Message 新增 useMessage hook,以支持 context 访问。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/message/demo/hooks.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 3, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 3, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 079e225:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #25422 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #25422   +/-   ##
========================================
  Coverage    99.51%   99.51%           
========================================
  Files          372      373    +1     
  Lines         7240     7284   +44     
  Branches      2027     2031    +4     
========================================
+ Hits          7205     7249   +44     
  Misses          35       35           
Impacted Files Coverage Δ
components/_util/usePatchElement.tsx 100.00% <ø> (ø)
components/message/hooks/useMessage.tsx 100.00% <100.00%> (ø)
components/message/index.tsx 100.00% <100.00%> (ø)
components/notification/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a65b47...079e225. Read the comment docs.

@07akioni 07akioni changed the title [WIP] Feat message hooks Feat message hooks Jul 7, 2020
components/message/demo/hooks.md Outdated Show resolved Hide resolved
zombieJ
zombieJ approved these changes Jul 9, 2020
@afc163
Copy link
Member

afc163 commented Jul 13, 2020

参考 notification 补充一下 FAQ。

@afc163
Copy link
Member

afc163 commented Jul 15, 2020

/rebase

afc163
afc163 approved these changes Jul 15, 2020
@07akioni 07akioni merged commit 01cec29 into feature Jul 15, 2020
22 checks passed
@07akioni 07akioni deleted the feat-message-hooks branch Jul 15, 2020
@07akioni 07akioni mentioned this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants