fix: support thumbnail for non-image files by upload onChange #25432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertAZ1992
changed the title
|
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ff245e6:
|
AlbertAZ1992
force-pushed
the
feat-show-thumbnail-upload-onchange
branch
from
e7d6c1c to
686ab31
Compare
Codecov Report
@@ Coverage Diff @@
## master #25432 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 368 368
Lines 7204 7204
Branches 2009 1962 -47
=======================================
Hits 7169 7169
Misses 35 35
Continue to review full report at Codecov.
|
|
目前使用upload 组件报这个警告，需要怎么操作？ [antd: Progress] |
afc163
reviewed
Jul 6, 2020
| </div> | ||
| </div> | ||
| </span> | ||
| </div> |
|
可以发到 master，作为一个 |
好的，稍等我改下 |
AlbertAZ1992
force-pushed
the
feat-show-thumbnail-upload-onchange
branch
from
f3c4a0d to
ff245e6
Compare
AlbertAZ1992
changed the title
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #25401
💡 Background and solution
isImageUrlcallisImageFileTypeto checkfile.typefirst when file was uploaded manually.so if
file.thumbUrlwas configured, skip that check.📝 Changelog
thumbUrlconfigured inonChangeeventonChange事件中设置thumbUrl来展示缩略图☑️ Self Check before Merge