Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi-drawer-push #25445

Merged
merged 1 commit into from Jul 12, 2020

Conversation

jinxin0112
Copy link
Contributor

@jinxin0112 jinxin0112 commented Jul 6, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #21382
reopen #25113

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Drawer support push prop for multi-Drawer linkage.(#21382)
🇨🇳 Chinese Drawer 增加 push 属性用于自定义多层级 Drawer 之间的联动(#21382)

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/drawer/demo/multi-level-drawer.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 6, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 6, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 46ef5cb:

Sandbox Source
antd reproduction template Configuration

@jinxin0112 jinxin0112 force-pushed the feat/drawer/multi-drawer-push branch from 3891d23 to 4062499 Compare Jul 6, 2020
@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #25445 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #25445   +/-   ##
========================================
  Coverage    99.51%   99.51%           
========================================
  Files          370      370           
  Lines         7209     7219   +10     
  Branches      2012     2015    +3     
========================================
+ Hits          7174     7184   +10     
  Misses          35       35           
Impacted Files Coverage Δ
components/drawer/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5cb860...46ef5cb. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Jul 6, 2020

  1. 补充 changelog
  2. 补充 test case
  3. 下面的选项需要都自检和勾选上

components/drawer/index.zh-CN.md Outdated Show resolved Hide resolved
components/drawer/index.en-US.md Outdated Show resolved Hide resolved
@xrkffgg
Copy link
Member

xrkffgg commented Jul 7, 2020

rebase 下

@jinxin0112 jinxin0112 force-pushed the feat/drawer/multi-drawer-push branch from 9a52d27 to 5300407 Compare Jul 7, 2020
components/drawer/index.en-US.md Outdated Show resolved Hide resolved
components/drawer/index.zh-CN.md Outdated Show resolved Hide resolved
@jinxin0112 jinxin0112 force-pushed the feat/drawer/multi-drawer-push branch from b62111b to 9411ca8 Compare Jul 9, 2020
components/drawer/index.tsx Outdated Show resolved Hide resolved
@jinxin0112 jinxin0112 force-pushed the feat/drawer/multi-drawer-push branch 2 times, most recently from c63eb14 to b8d741e Compare Jul 9, 2020
components/drawer/index.tsx Outdated Show resolved Hide resolved
@jinxin0112 jinxin0112 force-pushed the feat/drawer/multi-drawer-push branch 2 times, most recently from 8138c2a to 53db45b Compare Jul 9, 2020
components/drawer/index.tsx Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Jul 9, 2020

This pull request introduces 1 alert when merging 53db45b9bd2535d172d223b83a9eec8308f673f4 into d5cb860 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

components/drawer/index.tsx Outdated Show resolved Hide resolved
@jinxin0112 jinxin0112 force-pushed the feat/drawer/multi-drawer-push branch from 53db45b to 46ef5cb Compare Jul 9, 2020
@jinxin0112 jinxin0112 requested a review from afc163 Jul 9, 2020
@afc163
Copy link
Member

afc163 commented Jul 10, 2020

changelog 也可以更新一下了,更明确一点。

afc163
afc163 approved these changes Jul 12, 2020
@afc163 afc163 merged commit ad8aa87 into ant-design:feature Jul 12, 2020
23 checks passed
@07akioni 07akioni mentioned this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants