Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Badge.Ribbon #25456

Merged
merged 20 commits into from
Jul 8, 2020
Merged

feat: Badge.Ribbon #25456

merged 20 commits into from
Jul 8, 2020

Conversation

07akioni
Copy link
Contributor

@07akioni 07akioni commented Jul 6, 2020 •
edited by afc163
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #17768

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Add Badge.Ribbon component.
🇨🇳 Chinese 添加 Badge.Ribbon 缎带组件。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/badge/demo/ribbbon.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 6, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 6, 2020 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 6, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1e89ad2:

Sandbox Source
antd reproduction template Configuration

afc163
afc163 reviewed Jul 7, 2020
View reviewed changes
components/badge/Ribbon.tsx Outdated Show resolved Hide resolved
afc163
afc163 reviewed Jul 7, 2020
View reviewed changes
components/badge/Ribbon.tsx Outdated Show resolved Hide resolved
@07akioni 07akioni changed the title [WIP] feat: Badge.Ribbon, wip feat: Badge.Ribbon, wip Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020 •
edited
Loading

Codecov Report

Merging #25456 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #25456   +/-   ##
========================================
  Coverage    99.51%   99.51%           
========================================
  Files          368      370    +2     
  Lines         7208     7222   +14     
  Branches      2011     2006    -5     
========================================
+ Hits          7173     7187   +14     
  Misses          35       35
Impacted Files Coverage Δ
components/badge/Ribbon.tsx 100.00% <100.00%> (ø)
components/badge/index.tsx 100.00% <100.00%> (ø)
components/badge/utils.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36d7985...1e89ad2. Read the comment docs.

@07akioni 07akioni changed the title feat: Badge.Ribbon, wip feat: Badge.Ribbon Jul 7, 2020
xrkffgg
xrkffgg reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@xrkffgg xrkffgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  • 这个是不是太靠近了

xrkffgg
xrkffgg reviewed Jul 7, 2020
View reviewed changes
components/badge/index.zh-CN.md Outdated Show resolved Hide resolved
components/badge/index.en-US.md Outdated Show resolved Hide resolved
@07akioni @xrkffgg
Update components/badge/index.zh-CN.md
0374ca1 
Co-authored-by: xrkffgg <xrkffgg@gmail.com>
@07akioni @xrkffgg
Update components/badge/index.en-US.md
9b30765 
Co-authored-by: xrkffgg <xrkffgg@gmail.com>
@07akioni
Copy link
Contributor Author

07akioni commented Jul 7, 2020

image

  • 这个是不是太靠近了

这个感觉没啥问题，只是个例子，非得这么用说明用法不是很对= =，在这里躲开在其他地方会不好看的

afc163
afc163 reviewed Jul 7, 2020
View reviewed changes
components/badge/Ribbon.tsx Outdated Show resolved Hide resolved
afc163
afc163 reviewed Jul 7, 2020
View reviewed changes
components/badge/Ribbon.tsx Outdated Show resolved Hide resolved
@afc163 afc163 merged commit a73abb9 into feature Jul 8, 2020
@afc163 afc163 deleted the feat-badge-ribbon branch July 8, 2020 06:47
@07akioni 07akioni mentioned this pull request Jul 26, 2020
Merged
This was referenced Aug 15, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 approved these changes

@xrkffgg xrkffgg xrkffgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@07akioni @ant-design-bot @afc163 @xrkffgg