Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Description list plus extra operation area #25512

Merged
merged 8 commits into from Jul 14, 2020
Merged

Conversation

zzz111
Copy link
Contributor

@zzz111 zzz111 commented Jul 8, 2020

[中文版模板 / Chinese template]

feat:描述列表加 extra 操作区域

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

描述列表加 extra 操作区域

📝 Changelog

Language Changelog
🇺🇸 English Descriptions add extra prop.
🇨🇳 Chinese Descriptions 新增 extra 属性。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/descriptions/demo/basic.md
View rendered components/descriptions/index.en-US.md
View rendered components/descriptions/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 8, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 8, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9c6c38a:

Sandbox Source
antd reproduction template Configuration

@zzz111 zzz111 changed the title Wu descriptions feat:描述列表加 extra 操作区域 Jul 8, 2020
@zzz111 zzz111 changed the title feat:描述列表加 extra 操作区域 feat: Description list plus extra operation area Jul 8, 2020
@zombieJ
Copy link
Member

zombieJ commented Jul 9, 2020

feature branch

@chenshuai2144 chenshuai2144 changed the base branch from master to feature Jul 9, 2020
@afc163
Copy link
Member

afc163 commented Jul 9, 2020

image

应该居中对齐。

components/descriptions/index.tsx Outdated Show resolved Hide resolved
components/descriptions/index.tsx Outdated Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented Jul 13, 2020

ci broken

@zombieJ
Copy link
Member

zombieJ commented Jul 13, 2020

feature branch ood. Let me update feature first.

@zombieJ zombieJ mentioned this pull request Jul 13, 2020
13 tasks
@zombieJ
Copy link
Member

zombieJ commented Jul 13, 2020

Merged. Rebase again~

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #25512 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #25512   +/-   ##
========================================
  Coverage    99.51%   99.51%           
========================================
  Files          372      372           
  Lines         7230     7233    +3     
  Branches      2025     1979   -46     
========================================
+ Hits          7195     7198    +3     
  Misses          35       35           
Impacted Files Coverage Δ
components/descriptions/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 870138b...9c6c38a. Read the comment docs.

afc163
afc163 approved these changes Jul 14, 2020
@afc163 afc163 merged commit 4ec1b8a into feature Jul 14, 2020
33 checks passed
@afc163 afc163 deleted the wu-descriptions branch Jul 14, 2020
@07akioni 07akioni mentioned this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants