Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Card cover margin bug when bordered is false #25515

Merged
merged 1 commit into from Jul 8, 2020
Merged

Conversation

yutingzhao1991
Copy link
Contributor

@yutingzhao1991 yutingzhao1991 commented Jul 8, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

https://codepen.io/yutingzhao1991/pen/MWKGKJG?editors=0010

💡 Background and solution

Cover has a unexpected -1px margin when Card's bordered is false, should remove the margin.

image

📝 Changelog

Language Changelog
🇺🇸 English Fix Card cover margin bug when bordered is false
🇨🇳 Chinese 修复当 Card 组件无边框时封面图边距的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 8, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 8, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a0c0867:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #25515 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25515   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         368      368           
  Lines        7205     7205           
  Branches     1962     2009   +47     
=======================================
  Hits         7170     7170           
  Misses         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c26bb28...a0c0867. Read the comment docs.

@afc163 afc163 merged commit 260d40d into master Jul 8, 2020
37 checks passed
@afc163 afc163 deleted the fix/cardborder branch Jul 8, 2020
@zombieJ zombieJ mentioned this pull request Jul 11, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants