Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select showSearch align issue #25536

Merged
merged 5 commits into from Jul 9, 2020
Merged

Conversation

07akioni
Copy link
Contributor

@07akioni 07akioni commented Jul 9, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #24760

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Select shifts vertically when searching.
🇨🇳 Chinese 修正了 Select 在搜索时纵向漂移的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/select/demo/debug.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 9, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 9, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f505f2e:

Sandbox Source
antd reproduction template Configuration

@07akioni
Copy link
Contributor Author

07akioni commented Jul 9, 2020

nnd,又忘了 snapshot

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #25536 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25536   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         368      368           
  Lines        7192     7192           
  Branches     1959     2006   +47     
=======================================
  Hits         7157     7157           
  Misses         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e44d2...f505f2e. Read the comment docs.

components/select/demo/debug.md Outdated Show resolved Hide resolved
zombieJ
zombieJ approved these changes Jul 9, 2020
@07akioni 07akioni force-pushed the fix-select-after-line-height branch from 78aef50 to 55548db Compare Jul 9, 2020
@afc163
Copy link
Member

afc163 commented Jul 9, 2020

/rebase

@afc163 afc163 changed the title fix: selector ::after line-height fix: Select showSearch align issue Jul 9, 2020
@07akioni 07akioni merged commit 750931b into master Jul 9, 2020
34 checks passed
@07akioni 07akioni deleted the fix-select-after-line-height branch Jul 9, 2020
@zombieJ zombieJ mentioned this pull request Jul 11, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants