Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RangePicker onCalendarChange info support #25568

Merged
merged 5 commits into from Jul 10, 2020

Conversation

Kim-Wing-Fung
Copy link
Contributor

@Kim-Wing-Fung Kim-Wing-Fung commented Jul 10, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

https://github.com/react-component/picker/releases/tag/v1.12.1

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English RangePicker onCalendarChange info support
🇨🇳 Chinese RangePicker onCalendarChange 支持 info

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/date-picker/index.en-US.md
View rendered components/date-picker/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 10, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 10, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9ea6b13:

Sandbox Source
antd reproduction template Configuration

@yoyo837
Copy link
Contributor

yoyo837 commented Jul 10, 2020

I personally think that #25519 is more reasonable because the master branch is 4.4.x, which already includes this feature.

Unless we consider the different timings of exposing feature to documentation.

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #25568 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #25568   +/-   ##
========================================
  Coverage    99.51%   99.51%           
========================================
  Files          370      370           
  Lines         7209     7209           
  Branches      2012     2010    -2     
========================================
  Hits          7174     7174           
  Misses          35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5cb860...9ea6b13. Read the comment docs.

@Kim-Wing-Fung Kim-Wing-Fung requested a review from yoyo837 Jul 10, 2020
@zombieJ zombieJ merged commit 2bbdc2c into ant-design:feature Jul 10, 2020
22 checks passed
@07akioni 07akioni mentioned this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants