feat: Modal.config rootPrefixCls #25613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
|
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 043e12a:
|
Codecov Report
@@ Coverage Diff @@
## feature #25613 +/- ##
===========================================
- Coverage 99.51% 99.51% -0.01%
===========================================
Files 372 372
Lines 7238 7237 -1
Branches 2024 1977 -47
===========================================
- Hits 7203 7202 -1
Misses 35 35
Continue to review full report at Codecov.
|
xrkffgg
approved these changes
Jul 14, 2020
zombieJ
approved these changes
Jul 14, 2020
fireairforce
approved these changes
Jul 14, 2020
07akioni
approved these changes
Jul 14, 2020
07akioni
reviewed
Jul 14, 2020
components/modal/ActionButton.tsx
Outdated
| @@ -7,6 +7,7 @@ export interface ActionButtonProps { | |||
| actionFn?: (...args: any[]) => any | PromiseLike<any>; | |||
| closeModal: Function; | |||
| autoFocus?: boolean; | |||
| prefixCls?: string; | |||
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#25603 没能解决 #25586 (comment) 的问题。
💡 Background and solution
prefixCls不够用，因为 Modal.confirm 里面还有按钮，因此不支持prefixCls了，直接改成rootPrefixCls。📝 Changelog
Modal.configto setrootPrefixClsfor Modal statis methods.Modal.config用于全局配置 Modal 静态方法的rootPrefixCls.☑️ Self Check before Merge
View rendered components/modal/index.en-US.md
View rendered components/modal/index.zh-CN.md
View rendered docs/react/faq.en-US.md
View rendered docs/react/faq.zh-CN.md