Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modal.config rootPrefixCls #25613

Merged
merged 2 commits into from Jul 14, 2020
Merged

feat: Modal.config rootPrefixCls #25613

merged 2 commits into from Jul 14, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 14, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#25603 没能解决 #25586 (comment) 的问题。

💡 Background and solution

prefixCls 不够用,因为 Modal.confirm 里面还有按钮,因此不支持 prefixCls 了,直接改成 rootPrefixCls

📝 Changelog

Language Changelog
🇺🇸 English Add Modal.config to set rootPrefixCls for Modal statis methods.
🇨🇳 Chinese 新增 Modal.config 用于全局配置 Modal 静态方法的 rootPrefixCls.

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/modal/index.en-US.md
View rendered components/modal/index.zh-CN.md
View rendered docs/react/faq.en-US.md
View rendered docs/react/faq.zh-CN.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 14, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 14, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 043e12a:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #25613 into feature will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #25613      +/-   ##
===========================================
- Coverage    99.51%   99.51%   -0.01%     
===========================================
  Files          372      372              
  Lines         7238     7237       -1     
  Branches      2024     1977      -47     
===========================================
- Hits          7203     7202       -1     
  Misses          35       35              
Impacted Files Coverage Δ
components/modal/ConfirmDialog.tsx 95.23% <ø> (ø)
components/modal/ActionButton.tsx 100.00% <100.00%> (ø)
components/modal/confirm.tsx 97.91% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da8849...043e12a. Read the comment docs.

@@ -7,6 +7,7 @@ export interface ActionButtonProps {
actionFn?: (...args: any[]) => any | PromiseLike<any>;
closeModal: Function;
autoFocus?: boolean;
prefixCls?: string;
Copy link
Contributor

@07akioni 07akioni Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

从改动部分看起来这个是一定要有的

@afc163 afc163 merged commit cf42a16 into feature Jul 14, 2020
6 of 11 checks passed
@afc163 afc163 deleted the feat-modal-config-2 branch Jul 14, 2020
@07akioni 07akioni mentioned this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants