Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Input & Input.TextArea support bordered prop #25617

Merged
merged 3 commits into from Jul 15, 2020

Conversation

07akioni
Copy link
Contributor

@07akioni 07akioni commented Jul 14, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Input and Input.TextArea support bordered prop.
🇨🇳 Chinese Input 和 Input.TextArea 支持 bordered 属性。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/input/demo/borderless-debug.md
View rendered components/input/demo/borderless.md
View rendered components/input/index.en-US.md
View rendered components/input/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 14, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 14, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 517f327:

Sandbox Source
antd reproduction template Configuration

Copy link
Member

@xrkffgg xrkffgg left a comment

👍

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #25617 into feature will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #25617      +/-   ##
===========================================
- Coverage    99.51%   99.51%   -0.01%     
===========================================
  Files          372      372              
  Lines         7240     7238       -2     
  Branches      2027     2028       +1     
===========================================
- Hits          7205     7203       -2     
  Misses          35       35              
Impacted Files Coverage Δ
components/input/ClearableLabeledInput.tsx 100.00% <ø> (ø)
components/input/Input.tsx 100.00% <100.00%> (ø)
components/input/TextArea.tsx 100.00% <100.00%> (ø)
components/descriptions/index.tsx 100.00% <0.00%> (ø)
components/modal/ActionButton.tsx 100.00% <0.00%> (ø)
components/modal/ConfirmDialog.tsx 95.23% <0.00%> (ø)
components/modal/confirm.tsx 97.95% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a65b47...517f327. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Jul 15, 2020

应该是背景透明的。

image

@07akioni
Copy link
Contributor Author

07akioni commented Jul 15, 2020

应该是背景透明的。

image

说的对,改掉了

@07akioni 07akioni requested a review from afc163 Jul 15, 2020
afc163
afc163 approved these changes Jul 15, 2020
@07akioni
Copy link
Contributor Author

07akioni commented Jul 15, 2020

image
头一回见这玩意这么慢,不知道是不是 github 又出问题了

@07akioni 07akioni merged commit f937a7f into feature Jul 15, 2020
31 checks passed
@07akioni 07akioni deleted the feat-input-bordered branch Jul 15, 2020
@07akioni 07akioni mentioned this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants