Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table getCheckboxProps indeterminate not working #25649

Merged
merged 3 commits into from Jul 24, 2020

Conversation

07akioni
Copy link
Contributor

@07akioni 07akioni commented Jul 15, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #25646

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table indeterminate returned by getCheckboxProps not working.
🇨🇳 Chinese 修复 Table getCheckboxProps 返回的 indeterminate 不生效。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 24, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 24, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 75f157f:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #25649 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25649   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         369      369           
  Lines        7202     7207    +5     
  Branches     2016     2018    +2     
=======================================
+ Hits         7167     7172    +5     
  Misses         35       35           
Impacted Files Coverage Δ
components/table/hooks/useSelection.tsx 99.56% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c299f1c...75f157f. Read the comment docs.

@07akioni
Copy link
Contributor Author

07akioni commented Jul 24, 2020

我重命名了一下 expand-children.md,那个叫文档标题叫 Tree Data,每次看都忘了重新一个一个点。

@07akioni 07akioni changed the title [WIP] fix: Table getCheckboxProps indeterminate not working fix: Table getCheckboxProps indeterminate not working Jul 24, 2020
@zombieJ zombieJ merged commit 29da624 into master Jul 24, 2020
35 checks passed
@zombieJ zombieJ deleted the fix-table-selection branch Jul 24, 2020
@07akioni 07akioni mentioned this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants