Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Layout trigger #25653

Merged
merged 2 commits into from Jul 16, 2020
Merged

fix: Layout trigger #25653

merged 2 commits into from Jul 16, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 16, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #25433

💡 Background and solution

We can change zeroWidthTrigger icon by trigger now.

<Layout>
  <Sider collapsedWidth={0} trigger={<UserOutlined />} collapsible />
</Layout>

📝 Changelog

Language Changelog
🇺🇸 English Fix Layout trigger cannot customize zero width trigger.
🇨🇳 Chinese 修复 Layout trigger 属性无法定制零宽触发器的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 16, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 16, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7d5aa03:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #25653 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25653   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         368      368           
  Lines        7189     7191    +2     
  Branches     1964     1965    +1     
=======================================
+ Hits         7154     7156    +2     
  Misses         35       35           
Impacted Files Coverage Δ
components/layout/Sider.tsx 98.80% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5e6622...7d5aa03. Read the comment docs.

@afc163 afc163 merged commit 7bdd4fc into master Jul 16, 2020
35 checks passed
@afc163 afc163 deleted the fix-layout-trigger branch Jul 16, 2020
@ycjcl868 ycjcl868 mentioned this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants