Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add @zindex-popoconfirm #25693

Merged
merged 3 commits into from Jul 20, 2020
Merged

style: add @zindex-popoconfirm #25693

merged 3 commits into from Jul 20, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Jul 20, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #25600

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Add @zindex-popconfirm: 1060, and improve @zindex-tooltip to 1070.
🇨🇳 Chinese 新增 @zindex-popconfirm: 1060,并将 @zindex-tooltip 提升为1070。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163
Copy link
Member

afc163 commented Jul 20, 2020

#25600 (comment)

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 20, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 20, 2020

@xrkffgg
Copy link
Member Author

xrkffgg commented Jul 20, 2020

popoconfirm 使用的是 popover 的样式,要新弄个吗?

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 226b153:

Sandbox Source
antd reproduction template Configuration
friendly-dew-s5p7q Issue #25600

@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #25693 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25693   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         368      368           
  Lines        7191     7193    +2     
  Branches     2012     2005    -7     
=======================================
+ Hits         7156     7158    +2     
  Misses         35       35           
Impacted Files Coverage Δ
components/popconfirm/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd7331...226b153. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Jul 20, 2020

对,本质上是把 Popconfirm 变高。

@xrkffgg xrkffgg changed the title style: adjust @zindex-popover [WIP] style: adjust @zindex-popover Jul 20, 2020
@07akioni
Copy link
Contributor

07akioni commented Jul 20, 2020

tooltip 也变了,changelog 要写

@xrkffgg xrkffgg changed the title [WIP] style: adjust @zindex-popover [WIP] style: add @zindex-popoconfirm Jul 20, 2020
@xrkffgg xrkffgg changed the title [WIP] style: add @zindex-popoconfirm style: add @zindex-popoconfirm Jul 20, 2020
@xrkffgg xrkffgg requested review from afc163 and 07akioni Jul 20, 2020
@xrkffgg xrkffgg mentioned this pull request Jul 20, 2020
afc163
afc163 approved these changes Jul 20, 2020
@xrkffgg xrkffgg merged commit 309c8d4 into master Jul 20, 2020
34 checks passed
@xrkffgg xrkffgg deleted the z-index branch Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants