Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): 添加新语言支持zh-HK #25731

Merged
merged 1 commit into from Jul 21, 2020
Merged

Conversation

wuchu
Copy link
Contributor

@wuchu wuchu commented Jul 21, 2020

feat(locale): 添加新语言支持zh-HK,业务上TW繁体与HK繁体仍有差别,参考https://zh.wikipedia.org/wiki/%E7%B9%81%E4%BD%93%E5%AD%97#.E5.90.84.E5.9C.B0.E6.A8.99.E6.BA.96

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

添加新语言支持zh-HK,业务上TW繁体与HK繁体仍有差别,参考https://zh.wikipedia.org/wiki/%E7%B9%81%E4%BD%93%E5%AD%97#.E5.90.84.E5.9C.B0.E6.A8.99.E6.BA.96

📝 更新日志怎么写?

语言 更新描述
🇺🇸 英文
🇨🇳 中文 新增支持香港地区的默认语言文件支持

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

添加新语言支持zh-HK,业务上TW繁体与HK繁体仍有差别,参考https://zh.wikipedia.org/wiki/%E7%B9%81%E4%BD%93%E5%AD%97#.E5.90.84.E5.9C.B0.E6.A8.99.E6.BA.96
@wuchu wuchu changed the title feat(locale): 添加新语言支持zh-HK,业务上TW繁体与HK繁体仍有差别,参考 feat(locale): 添加新语言支持zh-HK Jul 21, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 21, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 21, 2020

@wuchu wuchu mentioned this pull request Jul 21, 2020
17 tasks
@yoyo837
Copy link
Contributor

yoyo837 commented Jul 21, 2020

先给
rc-pagination
rc-picker
提交zh_HK的locale PR 而不是直接使用zh_TW,是否更好一些呢?

然后在这些路径下一共需要5个文件,例如:

image

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aee722c:

Sandbox Source
antd reproduction template Configuration

@wuchu
Copy link
Contributor Author

wuchu commented Jul 21, 2020

先给
rc-pagination
rc-picker
提交zh_HK的locale PR 而不是直接使用zh_TW,是否更好一些呢?

然后在这些路径下一共需要5个文件,例如:

image

有道理,但是假如单纯地想业务层逻辑支持多一种繁体细化的语言zh-HK,而组件层默认仍然还是复用zh-TW,是否有更好的建议?

@yoyo837
Copy link
Contributor

yoyo837 commented Jul 21, 2020

作为一个新的locale 语言完整添加zh_HK即可,与zh_TW不产生关系。

@afc163
Copy link
Member

afc163 commented Jul 21, 2020

复用问题不大。

  • 文件名要补上。
  • 补充测试用例。
  • 补充文档。

@afc163 afc163 merged commit 877668b into ant-design:master Jul 21, 2020
23 of 24 checks passed
@07akioni 07akioni mentioned this pull request Jul 27, 2020
@wuchu wuchu deleted the patch-1 branch Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants