Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: using alert role in form-item-explain #25735

Merged
merged 1 commit into from Jul 21, 2020

Conversation

AlbertAZ1992
Copy link
Contributor

@AlbertAZ1992 AlbertAZ1992 commented Jul 21, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #25711

💡 Background and solution

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_alert_role

📝 Changelog

Language Changelog
🇺🇸 English Form add role="alert" attribute to validation message node.
🇨🇳 Chinese Form 错误信息节点增加属性 role="alert"

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 21, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 21, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eb21d71:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #25735 into feature will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #25735   +/-   ##
========================================
  Coverage    99.51%   99.51%           
========================================
  Files          373      373           
  Lines         7288     7288           
  Branches      2036     1987   -49     
========================================
  Hits          7253     7253           
  Misses          35       35           
Impacted Files Coverage Δ
components/form/FormItemInput.tsx 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d6647d...eb21d71. Read the comment docs.

afc163
afc163 approved these changes Jul 21, 2020
@afc163 afc163 merged commit 26f1d20 into ant-design:feature Jul 21, 2020
22 of 23 checks passed
@07akioni 07akioni mentioned this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants