Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update DatePicker docs and add legacy notice #25768

Merged
merged 6 commits into from Jul 23, 2020
Merged

docs: Update DatePicker docs and add legacy notice #25768

merged 6 commits into from Jul 23, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 23, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

resolve #25764

📝 Changelog

Language Changelog
🇺🇸 English 【需要写到 Changelog 里】 Adjust DatePicker doc to remove DatePicker.XxxPicker usage and add notice to recommend developer move to picker='xxx' instead.
🇨🇳 Chinese 【需要写到 Changelog 里】 调整 DatePicker 文档移除 DatePicker.XxxPicker 用法并于开发时推荐替换为 picker='xxx'

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/date-picker/demo/disabled.md
View rendered components/date-picker/index.en-US.md
View rendered components/date-picker/index.zh-CN.md
View rendered components/form/demo/time-related-controls.md
View rendered components/input/demo/align.md

search: 'devNote(',
replace: "if (process.env.NODE_ENV !== 'production') devNote(",
},
],
Copy link
Member

@afc163 afc163 Jul 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不加 warning 如何,应该大多数应用都会 warning 满天飞,我们就都支持。

Copy link
Member Author

@zombieJ zombieJ Jul 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那只给 QuarterPicker 加好了,本来就不支持这样不会遗留 warning 的问题了

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 23, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 23, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 23, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fa3b6ff:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #25764

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #25768 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25768   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         369      369           
  Lines        7197     7202    +5     
  Branches     2007     1966   -41     
=======================================
+ Hits         7162     7167    +5     
  Misses         35       35           
Impacted Files Coverage Δ
...ate-picker/generatePicker/generateSinglePicker.tsx 100.00% <100.00%> (ø)
components/date-picker/generatePicker/index.tsx 90.62% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9136b2...fa3b6ff. Read the comment docs.

@zombieJ zombieJ merged commit 2803ccf into master Jul 23, 2020
34 checks passed
@zombieJ zombieJ deleted the docs branch Jul 23, 2020
@07akioni 07akioni mentioned this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants