Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ⌨️ improve Alert/message/notification accessibility by adding role #25774

Merged
merged 1 commit into from Jul 23, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 23, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#25711
#22343

💡 Background and solution

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_alert_role

📝 Changelog

Language Changelog
🇺🇸 English Improve Alert/message/notification accessibility by adding role attribute.
🇨🇳 Chinese 提升 Alert/message/notification 组件的可访问性。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 23, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 23, 2020

@afc163
Copy link
Member Author

afc163 commented Jul 23, 2020

https://chakra-ui.com/ 里的各种标签用的很完整,可以挨个学习一波。

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 23, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1c6e6db:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #25774 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25774   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         369      369           
  Lines        7197     7197           
  Branches     2007     2016    +9     
=======================================
  Hits         7162     7162           
  Misses         35       35           
Impacted Files Coverage Δ
components/alert/index.tsx 100.00% <ø> (ø)
components/message/index.tsx 100.00% <ø> (ø)
components/notification/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9136b2...1c6e6db. Read the comment docs.

@afc163 afc163 merged commit 436465b into master Jul 23, 2020
34 checks passed
@afc163 afc163 deleted the role-alert branch Jul 23, 2020
@07akioni 07akioni mentioned this pull request Jul 26, 2020
@afc163 afc163 mentioned this pull request Jul 27, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants