Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(date-picker): improve hovering experience #25784

Merged
merged 1 commit into from Jul 23, 2020
Merged

feat(date-picker): improve hovering experience #25784

merged 1 commit into from Jul 23, 2020

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Jul 23, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #25050

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English improve DatePicker hovering experience, the placeholder will change to format value of target-date when hovering a date cell. (#25050)
🇨🇳 Chinese 提升日期组件悬停体验,当悬停在某个日期上时占位符将变为对应的日期格式化后的值。(#25050)

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@kerm1it kerm1it requested review from zombieJ and afc163 and removed request for afc163 Jul 23, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 23, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 23, 2020

@kerm1it
Copy link
Member Author

kerm1it commented Jul 23, 2020

Jul-23-2020 20-57-06

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 23, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6e9cfa9:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #25784 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #25784   +/-   ##
========================================
  Coverage    99.52%   99.52%           
========================================
  Files          374      374           
  Lines         7292     7292           
  Branches      1988     2038   +50     
========================================
  Hits          7257     7257           
  Misses          35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a075f3...6e9cfa9. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Jul 23, 2020

Changelog 里需要写的更详细些,比如悬停时间时输入框会同步展示对应时间之类的。

@kerm1it
Copy link
Member Author

kerm1it commented Jul 23, 2020

Changelog 里需要写的更详细些,比如悬停时间时输入框会同步展示对应时间之类的。

看看现在呢?

@kerm1it kerm1it changed the title feat(date-picker): improve hovering experience feat(date-picker): improve hovering experience Jul 23, 2020
@kerm1it kerm1it merged commit d52965e into feature Jul 23, 2020
34 checks passed
@kerm1it kerm1it deleted the feat-25050 branch Jul 23, 2020
@afc163
Copy link
Member

afc163 commented Jul 24, 2020

image

这种已选的情况能支持么,hover 修改为 placeholder 样式,离开恢复。

@afc163
Copy link
Member

afc163 commented Jul 24, 2020

#25050 里的最后一个图。

@kerm1it
Copy link
Member Author

kerm1it commented Jul 24, 2020

你意思是已经选择了值后,这时候再悬停的时候还想要变成目标日期,然后离开后恢复为原值?

@afc163
Copy link
Member

afc163 commented Jul 24, 2020

@kerm1it
Copy link
Member Author

kerm1it commented Jul 24, 2020

有道理,这种体验确实更好,晚上我再改改。

@07akioni 07akioni mentioned this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants