Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avatar fallback bug #25806

Merged
merged 4 commits into from Jul 26, 2020
Merged

fix: Avatar fallback bug #25806

merged 4 commits into from Jul 26, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 25, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #25801

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Avatar not fallback correctly when src is invalid.
🇨🇳 Chinese 修复 Avatar src 图片地址失效时没有正确 fallback 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/avatar/demo/fallback.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 25, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 25, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 25, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 929f6c0:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 25, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f0cb35e:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 25, 2020

Codecov Report

Merging #25806 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25806      +/-   ##
==========================================
- Coverage   99.51%   99.51%   -0.01%     
==========================================
  Files         369      369              
  Lines        7207     7201       -6     
  Branches     2018     1967      -51     
==========================================
- Hits         7172     7166       -6     
  Misses         35       35              
Impacted Files Coverage Δ
components/avatar/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16c0ca9...f0cb35e. Read the comment docs.

@afc163 afc163 merged commit fca0da3 into master Jul 26, 2020
31 of 35 checks passed
@afc163 afc163 deleted the fix-avatar-fallback branch Jul 26, 2020
@07akioni 07akioni mentioned this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants