-
-
Notifications
You must be signed in to change notification settings - Fork 48.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tabs): focus state color when disabled #25827
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e80991b:
|
@@ -183,6 +183,14 @@ | |||
cursor: not-allowed; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not write after this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I'm not familiar with less, do you have any good suggestions for me?
like this? I think the readability is not good.
&&-disabled {
color: @disabled-color;
cursor: not-allowed;
.@{tab-prefix-cls}-tab-btn,
.@{tab-prefix-cls}-tab--remove {
&:focus,
&:active {
color: @disabled-color;
}
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about pointer-events: none
?
/rebase |
fd06113
to
e80991b
Compare
Codecov Report
@@ Coverage Diff @@
## master #25827 +/- ##
=======================================
Coverage 99.52% 99.52%
=======================================
Files 374 374
Lines 7300 7300
Branches 2037 1989 -48
=======================================
Hits 7265 7265
Misses 35 35 Continue to review full report at Codecov.
|
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
https://codesandbox.io/s/serene-wiles-gtu01
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge