Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: steps progress #25839

Merged
merged 12 commits into from Jul 27, 2020
Merged

feat: steps progress #25839

merged 12 commits into from Jul 27, 2020

Conversation

07akioni
Copy link
Contributor

@07akioni 07akioni commented Jul 27, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English Steps support percent prop to show step icon progress.
🇨🇳 Chinese Steps 新增 percent 属性来展示步骤图标的进度。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/steps/demo/progress-debug.md
View rendered components/steps/demo/progress.md
View rendered components/steps/index.en-US.md
View rendered components/steps/index.zh-CN.md

@07akioni 07akioni changed the base branch from master to feature Jul 27, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 27, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 27, 2020

components/steps/index.en-US.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Co-authored-by: 偏右 <afc163@gmail.com>
components/steps/demo/progress.md Outdated Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented Jul 27, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9dea45b:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #25839 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #25839   +/-   ##
========================================
  Coverage    99.52%   99.52%           
========================================
  Files          374      374           
  Lines         7300     7309    +9     
  Branches      2037     2041    +4     
========================================
+ Hits          7265     7274    +9     
  Misses          35       35           
Impacted Files Coverage Δ
components/steps/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3247772...de64267. Read the comment docs.

// currently it's hard-coded, since we can't easily read the actually width of icon
const progressWidth = size === 'small' ? 30 : 38;
const iconWithProgress = (
<div className={`${prefixCls}-progress-icon`}>
<Progress
type="circle"
percent={percentage}
percent={percent}
Copy link
Member

@afc163 afc163 Jul 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

叫 currentPercent 会不会更准确一点?

Copy link
Contributor Author

@07akioni 07akioni Jul 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉必要不大?用户真的想改给他们 上面改的机会吧,status 也没有叫 currentStatus

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit de64267:

Sandbox Source
antd reproduction template Configuration

@07akioni
Copy link
Contributor Author

07akioni commented Jul 27, 2020

@zombieJ
Copy link
Member

zombieJ commented Jul 27, 2020

不紧贴了:
截屏2020-07-27 下午8 42 11

原:
截屏2020-07-27 下午8 42 21

@07akioni 07akioni merged commit c2f208e into feature Jul 27, 2020
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants