-
-
Notifications
You must be signed in to change notification settings - Fork 49.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: steps progress #25839
feat: steps progress #25839
Conversation
Co-authored-by: 偏右 <afc163@gmail.com>
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9dea45b:
|
Codecov Report
@@ Coverage Diff @@
## feature #25839 +/- ##
========================================
Coverage 99.52% 99.52%
========================================
Files 374 374
Lines 7300 7309 +9
Branches 2037 2041 +4
========================================
+ Hits 7265 7274 +9
Misses 35 35
Continue to review full report at Codecov.
|
// currently it's hard-coded, since we can't easily read the actually width of icon | ||
const progressWidth = size === 'small' ? 30 : 38; | ||
const iconWithProgress = ( | ||
<div className={`${prefixCls}-progress-icon`}> | ||
<Progress | ||
type="circle" | ||
percent={percentage} | ||
percent={percent} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
叫 currentPercent 会不会更准确一点?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉必要不大?用户真的想改给他们 上面改的机会吧,status 也没有叫 currentStatus
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit de64267:
|
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
percent
prop to show step icon progress.percent
属性来展示步骤图标的进度。☑️ Self Check before Merge
View rendered components/steps/demo/progress-debug.md
View rendered components/steps/demo/progress.md
View rendered components/steps/index.en-US.md
View rendered components/steps/index.zh-CN.md