Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: menu horizontal dark style & site #25850

Merged
merged 6 commits into from Jul 28, 2020
Merged

fix: menu horizontal dark style & site #25850

merged 6 commits into from Jul 28, 2020

Conversation

07akioni
Copy link
Contributor

@07akioni 07akioni commented Jul 28, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #25845
ref f0509f0#comments

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Menu in horizontal dark status Menu.Item background style glitch.
🇨🇳 Chinese 修复 Menu 在 horizontal dark 状态下 Menu.Item 背景样式出错。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/menu/demo/style-debug.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 28, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 28, 2020

@07akioni 07akioni changed the title fix: menu horizontal dark style & site [WIP] fix: menu horizontal dark style & site Jul 28, 2020
@afc163
Copy link
Member

afc163 commented Jul 28, 2020

紧凑版也看看。

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0fb8c9a:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #25845

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #25850 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25850   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files         374      374           
  Lines        7309     7309           
  Branches     2032     2032           
=======================================
  Hits         7274     7274           
  Misses         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72fb1c7...0fb8c9a. Read the comment docs.

@xrkffgg
Copy link
Member

xrkffgg commented Jul 28, 2020

RTL 别忘了哟

@07akioni 07akioni changed the title [WIP] fix: menu horizontal dark style & site fix: menu horizontal dark style & site Jul 28, 2020
@07akioni
Copy link
Contributor Author

07akioni commented Jul 28, 2020

紧凑主题和 Dark 主题的 dark menu 预览还是存在问题。不过 dist/antd.dark.js 是没啥问题,应该是 work 的。

给构建工具提了个 issue

ref chenshuai2144/antd-pro-merge-less#21

afc163
afc163 approved these changes Jul 28, 2020
@07akioni 07akioni requested a review from afc163 Jul 28, 2020
@07akioni 07akioni merged commit f498ae0 into master Jul 28, 2020
37 checks passed
@07akioni 07akioni deleted the fix-menu-dark-style branch Jul 28, 2020
@07akioni 07akioni mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants