Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove Select choice animation #25852

Merged
merged 1 commit into from Jul 28, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 28, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#25787 (comment)

💡 Background and solution

移除选项动画后,交互体验会流畅很多。

📝 Changelog

Language Changelog
🇺🇸 English Remove multiple Select choice animation of item.
🇨🇳 Chinese 移除多选 Select 选项的动画效果使交互更流畅。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 requested a review from zombieJ as a code owner Jul 28, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 28, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 28, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 156012b:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #25852 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25852   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files         374      374           
  Lines        7309     7309           
  Branches     2032     1991   -41     
=======================================
  Hits         7274     7274           
  Misses         35       35           
Impacted Files Coverage Δ
components/select/index.tsx 100.00% <ø> (ø)
components/tree-select/index.tsx 97.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72fb1c7...156012b. Read the comment docs.

@afc163 afc163 merged commit f4e76c6 into master Jul 28, 2020
37 checks passed
@afc163 afc163 deleted the select-choice-animation branch Jul 28, 2020
@07akioni 07akioni mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants