Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Menu support expandIcon #27565

Merged
merged 3 commits into from Nov 6, 2020
Merged

feat: Menu support expandIcon #27565

merged 3 commits into from Nov 6, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 5, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20035

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Menu supports expandIcon, and optimize default expand icon style.
🇨🇳 Chinese Menu 新增 expandIcon 属性以支持自定义展开图标,同时优化了默认图标的样式。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/menu/index.en-US.md
View rendered components/menu/index.zh-CN.md

@afc163 afc163 changed the base branch from master to feature November 5, 2020 05:45
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 5, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2020

Size Change: -961 B (0%)

Total Size: 790 kB

Filename Size Change
./dist/antd-with-locales.min.js 313 kB +90 B (0%)
./dist/antd.compact.min.css 66.1 kB -379 B (0%)
./dist/antd.dark.min.css 67.4 kB -397 B (0%)
./dist/antd.min.css 66.1 kB -378 B (0%)
./dist/antd.min.js 277 kB +103 B (0%)

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit db17b9c:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #27565 into feature will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           feature    #27565   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7404      7404           
  Branches      2087      2038   -49     
=========================================
  Hits          7404      7404           
Impacted Files Coverage Δ
components/menu/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7630216...db17b9c. Read the comment docs.

@@ -539,7 +539,7 @@
@menu-collapsed-width: 80px;
@menu-bg: @component-background;
@menu-popup-bg: @component-background;
@menu-item-color: @text-color;
@menu-item-color: #555;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个暗色主题下会不会有问题?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有道理,我检查一下。

@afc163 afc163 merged commit 756a1df into feature Nov 6, 2020
@afc163 afc163 deleted the feat-menu-expand-icon branch November 6, 2020 07:25
@jljsj33
Copy link
Member

jljsj33 commented Nov 9, 2020

我觉得你缓动可以不用改,,默认缓动很平庸。。。

yoyo837 pushed a commit that referenced this pull request Nov 19, 2020
* style: optimize menu expand icon color

close #20035

* feat: 🆕 support Menu expandIcon

* revert arrow color
@zombieJ zombieJ mentioned this pull request Nov 30, 2020
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

menu 组件的箭头样式
6 participants