Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RangePicker panel style & picker 2.4.0 #27894

Merged
merged 4 commits into from Nov 20, 2020
Merged

fix: RangePicker panel style & picker 2.4.0 #27894

merged 4 commits into from Nov 20, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Nov 20, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #27798

💡 Background and solution

close #27828

react-component/picker#175

起初给 picker 加 start end 觉得有点消耗性能。
装到 antd 上,感觉有点卡顿,大家预览看一下,也许是我错觉。同时这样可以完美解决样式问题。

大家什么看法?或者 picker 再优化优化,我的想法如果卡顿解决不了,这个最好不加。

📝 Changelog

Language Changelog
🇺🇸 English Fix the RangePicker panel interaction style.
🇨🇳 Chinese 修复 RangePicker 面板交互样式。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: draft label Nov 20, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 20, 2020

@xrkffgg
Copy link
Member Author

xrkffgg commented Nov 20, 2020

snap 没更新报错先不管

@xrkffgg
Copy link
Member Author

xrkffgg commented Nov 20, 2020

看预览比我本地好多了。。。本地有点卡。。。

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cd15816:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2020

Size Change: +282 B (0%)

Total Size: 788 kB

Filename Size Change
./dist/antd-with-locales.min.js 312 kB +150 B (0%)
./dist/antd.compact.min.css 66.5 kB +1 B
./dist/antd.dark.min.css 67.7 kB -43 B (0%)
./dist/antd.min.css 66.5 kB +2 B (0%)
./dist/antd.min.js 276 kB +172 B (0%)

compressed-size-action

@AlanCutFlim
Copy link
Contributor

我这里不卡,好像没有问题

@yoyo837
Copy link
Contributor

yoyo837 commented Nov 20, 2020

我这里不卡

@xrkffgg
Copy link
Member Author

xrkffgg commented Nov 20, 2020

OK 那我完善一下

@yoyo837
Copy link
Contributor

yoyo837 commented Nov 20, 2020

@AlanCutFlim 来验证这个修复感觉会比较全面 😂

@AlanCutFlim
Copy link
Contributor

AlanCutFlim commented Nov 20, 2020

ltr 下我看着是没啥问题,我也是误打误撞发现 Picker 的一些问题的 😂

@xrkffgg
Copy link
Member Author

xrkffgg commented Nov 20, 2020

电脑好卡,看来得换 M1 了 😎

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #27894 (cd15816) into master (3269dd3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27894   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7320      7320           
  Branches      2045      2098   +53     
=========================================
  Hits          7320      7320           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3269dd3...cd15816. Read the comment docs.

@xrkffgg xrkffgg marked this pull request as ready for review November 20, 2020 09:26
@xrkffgg
Copy link
Member Author

xrkffgg commented Nov 20, 2020

/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RangePicker] Missing border style when hover range starts from first day of a month
4 participants