New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Grid flexGap lazy check #29202
fix: Grid flexGap lazy check #29202
Conversation
Codecov Report
@@ Coverage Diff @@
## master #29202 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 394 394
Lines 7482 7483 +1
Branches 2140 2141 +1
=========================================
+ Hits 7482 7483 +1
Continue to review full report at Codecov.
|
if (!canUseDocElement()) { | ||
return false; | ||
} | ||
|
||
if (flexGapSupported !== undefined) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
位置可以放到最上面
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
放下面是为了减少 canUseDocElement 分支还得写一个赋值,节省一行代码。
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 30e8e0a:
|
Size Change: -40 B (0%) Total Size: 836 kB
ℹ️ View Unchanged
|
不必使用,umd 包引入即报错。 |
rename 一下测试挂了,一脸懵逼…… |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #29200
fix #29201
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge