Skip to content

chore: Not preventEvent btn loading - #32158

Merged
zombieJ merged 2 commits into
masterfrom
btn-loading
Sep 14, 2021
Merged

zombieJ merged 2 commits into
masterfrom
btn-loading

Conversation

@zombieJ

@zombieJ zombieJ commented Sep 14, 2021

Copy link
Copy Markdown
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #32109

💡 Background and solution

放出 loading 可点击。现在淡色下会有 hover & active & focus 样式,考虑到之后转 cssinjs 需要,这边先不做规则了。

📝 Changelog

Language Changelog
🇺🇸 English Fix Button with loading can not trigger Tooltip.
🇨🇳 Chinese 修复 Button 配置 loading 时,无法触发 Tooltip 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions

github-actions Bot commented Sep 14, 2021 •

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Sep 14, 2021 •

Copy link
Copy Markdown
Contributor

Size Change: +20 B (0%)

Total Size: 917 kB

Filename Size Change
./dist/antd-with-locales.min.js 353 kB +13 B (0%)
./dist/antd.compact.min.css 64.8 kB -3 B (0%)
./dist/antd.dark.min.css 66.2 kB -2 B (0%)
./dist/antd.min.css 65 kB +1 B (0%)
./dist/antd.min.js 303 kB +11 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/antd.variable.min.css 65.5 kB

compressed-size-action

@yoyo837

yoyo837 commented Sep 14, 2021 •

Copy link
Copy Markdown
Contributor

So b..........i...........g break changes.

@zombieJ

zombieJ commented Sep 14, 2021

Copy link
Copy Markdown
Member Author

So b..........i...........g break changes.

Why?

@yoyo837

yoyo837 commented Sep 14, 2021

Copy link
Copy Markdown
Contributor

看错了. 哥.

@codecov

codecov Bot commented Sep 14, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #32158 (91e4bd8) into master (0e3171c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32158      +/-   ##
==========================================
+ Coverage   99.94%   99.96%   +0.01%     
==========================================
  Files         414      414              
  Lines        7675     7575     -100     
  Branches     2175     2122      -53     
==========================================
- Hits         7671     7572      -99     
+ Misses          4        3       -1     
Impacted Files Coverage Δ
components/_util/wave.tsx 100.00% <100.00%> (ø)
components/button/button.tsx 100.00% <100.00%> (ø)
components/upload/Upload.tsx 100.00% <0.00%> (ø)
components/upload/UploadList/index.tsx 100.00% <0.00%> (ø)
components/upload/UploadList/ListItem.tsx 100.00% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e3171c...91e4bd8. Read the comment docs.

@zombieJ
zombieJ merged commit 9324e95 into master Sep 14, 2021
@zombieJ
zombieJ deleted the btn-loading branch September 14, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The tooltip remains displayed when the loading property of a button with an icon and no text is set to true

2 participants