Repository navigation
fix: the computed fontSize style may be empty string - #37928
Merged
Merged
Conversation
Contributor
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #37928 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 443 443
Lines 8254 8254
Branches 2488 2489 +1
=========================================
Hits 8254 8254
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zheeeng
marked this pull request as ready for review
October 11, 2022 03:38
afc163
approved these changes
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
一些元素的 fontSize 计算结果是 '',导致 parseInt 算出来是
NaN📝 Changelog
fontSizestyle be calculated as empty string☑️ Self-Check before Merge