Skip to content

fix: the computed fontSize style may be empty string - #37928

Merged
afc163 merged 2 commits into
ant-design:masterfrom
zheeeng:fix-empty-font-size
Oct 11, 2022
Merged

afc163 merged 2 commits into
ant-design:masterfrom
zheeeng:fix-empty-font-size

Conversation

@zheeeng

@zheeeng zheeeng commented Oct 11, 2022 •

Copy link
Copy Markdown
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

一些元素的 fontSize 计算结果是 '',导致 parseInt 算出来是 NaN

📝 Changelog

Language Changelog
🇺🇸 English fix the cases that the computed fontSize style be calculated as empty string
🇨🇳 Chinese 修复一些元素计算 fontSize 时为空字符串的情况

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions

github-actions Bot commented Oct 11, 2022 •

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Oct 11, 2022 •

Copy link
Copy Markdown

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (f954ab1) compared to base (44eb250).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head f954ab1 differs from pull request most recent head 709df8a. Consider uploading reports for the commit 709df8a to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #37928   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          443       443           
  Lines         8254      8254           
  Branches      2488      2489    +1     
=========================================
  Hits          8254      8254           
Impacted Files Coverage Δ
components/typography/Base/index.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zheeeng
zheeeng marked this pull request as ready for review October 11, 2022 03:38
@afc163
afc163 merged commit 8fc5af0 into ant-design:master Oct 11, 2022
@MadCcc MadCcc mentioned this pull request Oct 14, 2022
19 tasks
@zombieJ zombieJ mentioned this pull request Oct 17, 2022
1 of 15 tasks
@MadCcc MadCcc mentioned this pull request Oct 17, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants