Skip to content

Revert "fix(table): aria-label should be use the first text content in element when column title is ReactElement in table" - #38383

Merged
zombieJ merged 2 commits into
masterfrom
revert-38160-fix/38155
Nov 4, 2022
Merged

zombieJ merged 2 commits into
masterfrom
revert-38160-fix/38155

Conversation

@zombieJ

@zombieJ zombieJ commented Nov 4, 2022 •

Copy link
Copy Markdown
Member

Reverts #38160
close #38371

…n element when column title is ReactElement in table (#38160)"

This reverts commit 21c4bcf.
@github-actions

github-actions Bot commented Nov 4, 2022 •

Copy link
Copy Markdown
Contributor

@zombieJ zombieJ changed the title Revert "fix(table): aria-label should be use the first text content in element when column title is ReactElement in table" [] WIP Revert "fix(table): aria-label should be use the first text content in element when column title is ReactElement in table" Nov 4, 2022
@zombieJ zombieJ changed the title [] WIP Revert "fix(table): aria-label should be use the first text content in element when column title is ReactElement in table" [WIP] Revert "fix(table): aria-label should be use the first text content in element when column title is ReactElement in table" Nov 4, 2022
@github-actions

github-actions Bot commented Nov 4, 2022 •

Copy link
Copy Markdown
Contributor

Size Change: -178 B (0%)

Total Size: 963 kB

Filename Size Change
./dist/antd-with-locales.min.js 374 kB -98 B (0%)
./dist/antd.min.js 316 kB -80 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/antd.compact.min.css 67.6 kB
./dist/antd.dark.min.css 68.9 kB
./dist/antd.min.css 67.6 kB
./dist/antd.variable.min.css 68.2 kB

compressed-size-action

@zombieJ zombieJ changed the title [WIP] Revert "fix(table): aria-label should be use the first text content in element when column title is ReactElement in table" Revert "fix(table): aria-label should be use the first text content in element when column title is ReactElement in table" Nov 4, 2022
@codecov

codecov Bot commented Nov 4, 2022 •

Copy link
Copy Markdown

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (759c178) compared to base (e80e40b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38383   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          446       446           
  Lines         8304      8295    -9     
  Branches      2526      2520    -6     
=========================================
- Hits          8304      8295    -9     
Impacted Files Coverage Δ
components/table/util.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ
zombieJ merged commit 216f25c into master Nov 4, 2022
@zombieJ
zombieJ deleted the revert-38160-fix/38155 branch November 4, 2022 08:18
@zombieJ zombieJ mentioned this pull request Nov 4, 2022
1 of 15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table的title属性使用函数和直接传入ReactNode行为不一致

3 participants