Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix Popover width in rtl mode #39311

Merged
merged 1 commit into from Dec 6, 2022
Merged

style: fix Popover width in rtl mode #39311

merged 1 commit into from Dec 6, 2022

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Dec 6, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #39195

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Popover width in rtl mode.
🇨🇳 Chinese 修复 Popover 在 rtl 模式下宽度异常的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

size-limit report 📦

Path Size
./dist/antd.min.js 373.58 KB (+0.01% 🔺)
./dist/antd-with-locales.min.js 427.05 KB (+0.01% 🔺)

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (9793a84) compared to base (a59058f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39311   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          546       546           
  Lines         9364      9364           
  Branches      2653      2653           
=========================================
  Hits          9364      9364           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member Author

afc163 commented Dec 6, 2022

谁在帮忙 CR 一下

@Yuiai01
Copy link
Contributor

Yuiai01 commented Dec 6, 2022

谁在帮忙 CR 一下

大佬还是你强啊,本来想着今天晚上看一下,结果都修复了

@afc163 afc163 merged commit a8dd587 into master Dec 6, 2022
@afc163 afc163 deleted the style/popover-rtl branch December 6, 2022 15:29
@zombieJ zombieJ mentioned this pull request Dec 8, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTL时Popover组件显示不正确
4 participants