chore: improve Form.Item on Require judgment logic #41623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #41623 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 614 614
Lines 10496 10497 +1
Branches 2873 2874 +1
=========================================
+ Hits 10496 10497 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
zombieJ
approved these changes
Apr 4, 2023
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* test: add case * chore: improve `Form.Item` on Require judgment logic
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* test: add case * chore: improve `Form.Item` on Require judgment logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #41621
💡 Background and solution
📝 Changelog
Form.Itemon Require judgment logicForm.Item关于 Require 判断逻辑☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at c37f6f5
This pull request adds a new feature and fixes a bug for the form component. It enables the user to customize the required mark of the form item label with a new
requiredprop, and ensures that the required mark is displayed correctly when therequiredprop isundefined. It also updates the test filecomponents/form/__tests__/index.test.tsxto cover the new feature and the bug fix.🔍 Walkthrough
🤖 Generated by Copilot at c37f6f5
requiredto theItemHoldercomponent to indicate whether the form item is required or not (link)requiredprop from theItemHoldercomponent to theFormItemLabelcomponent and use it to override theisRequiredprop (link)'required'string from theclassNameof the form item wrapper and use therequiredprop instead (link)requiredprop isundefinedand therulesprop contains arequired: truerule incomponents/form/__tests__/index.test.tsx(link)