Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance tag type #42235

Merged
merged 1 commit into from May 9, 2023
Merged

fix: enhance tag type #42235

merged 1 commit into from May 9, 2023

Conversation

gaoqiiii
Copy link
Contributor

@gaoqiiii gaoqiiii commented May 9, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix: enhance tag type
🇨🇳 Chinese fix: 优化类型

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 856c35e

Improved the TypeScript definitions of the Tag component and other components in the ant-design library. Used a more specific ref type for the Tag component in components/tag/index.tsx.

🔍 Walkthrough

🤖 Generated by Copilot at 856c35e

  • Update the ref type of Tag component to HTMLSpanElement for better type safety and compatibility (link)

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (24dd535) 100.00% compared to head (856c35e) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #42235    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          619       617     -2     
  Lines        11048     10529   -519     
  Branches      3081      2876   -205     
==========================================
- Hits         11048     10529   -519     
Impacted Files Coverage Δ
components/tag/index.tsx 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jia-nan li-jia-nan merged commit 492dbbe into ant-design:master May 9, 2023
77 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants