fix: Fix image group preview z index in nested modal #46035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Settings did not meet expectations
… Settings did not meet expectations
… Settings did not meet expectations
|
|
|
|
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8db8cd8:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #46035 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 700 700
Lines 11855 11908 +53
Branches 3160 3180 +20
=========================================
+ Hits 11855 11908 +53 ☔ View full report in Codecov by Sentry. |
zombieJ
approved these changes
Nov 23, 2023
afc163
reviewed
Nov 23, 2023
kiner-tang
changed the title
kiner-tang
changed the title
MadCcc
approved these changes
Nov 24, 2023
|
Same Problem when a notification has a tooltip in message content. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #46034
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖[deprecated] Generated by Copilot at 0b7ff02
This pull request adds a new feature to the
Image.PreviewGroupcomponent that allows users to customize the z-index of the modal that shows the image preview group. It also adds a new demo example of using theImage.PreviewGroupcomponent nested in a modal, and updates the documentation and tests accordingly.🔍 Walkthrough
🤖[deprecated] Generated by Copilot at 0b7ff02
Image.PreviewGroupcomponent to support previewing multiple images in a group with a modal (link, link, link, link, link, link)useZIndexhook to get the z-index value for theImage.PreviewGroupcomponent and pass it to theModalcomponent (link, link, link)useZIndexhook with theImage.PreviewGroupcomponent in theuseZIndex.test.tsxfile (link, link, link)Image.PreviewGroupcomponent nested in a modal in theimage/demofolder and the documentation files (link, link, link, link)