feat(Segmented): unify orientation attribute usage - #53664
Merged
thinkasany merged 10 commits intoMay 19, 2025
Conversation
|
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
|
|
Contributor
👁 Visual Regression Report for PR #53664 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| if (orientation) { | ||
| return orientation === 'vertical'; | ||
| } | ||
| return vertical ?? ctxVertical ?? false; |
There was a problem hiding this comment.
The use of ?? operator here is appropriate for handling undefined values, ensuring that vertical or ctxVertical defaults to false if neither is provided. This logic is crucial for determining the correct orientation.
More templates
commit: |
Bundle ReportChanges will decrease total bundle size by 7.76MB (-67.43%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
thinkasany
reviewed
Apr 27, 2025
EmilyyyLiu
changed the title
EmilyyyLiu
force-pushed
the
next-segmented-orientation
branch
from
April 28, 2025 08:44
9bf0a5c to
54d54c2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #53664 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 788 788
Lines 14304 14305 +1
Branches 3786 3785 -1
=========================================
+ Hits 14304 14305 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EmilyyyLiu
force-pushed
the
next-segmented-orientation
branch
3 times, most recently
from
May 9, 2025 08:33
0413b66 to
c425e74
Compare
thinkasany
reviewed
May 13, 2025
thinkasany
reviewed
May 19, 2025
Co-authored-by: thinkasany <480968828@qq.com> Signed-off-by: EmilyyyLiu <100924403+EmilyyyLiu@users.noreply.github.com>
Co-authored-by: thinkasany <480968828@qq.com> Signed-off-by: EmilyyyLiu <100924403+EmilyyyLiu@users.noreply.github.com>
Signed-off-by: EmilyyyLiu <100924403+EmilyyyLiu@users.noreply.github.com>
EmilyyyLiu
force-pushed
the
next-segmented-orientation
branch
from
May 19, 2025 06:21
c7bdc85 to
69aef81
Compare
Co-authored-by: thinkasany <480968828@qq.com> Signed-off-by: EmilyyyLiu <100924403+EmilyyyLiu@users.noreply.github.com>
thinkasany
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
FRC #53328
📝 Change Log