feat(collapse): Support better customization with semantic classNames/styles as function by meet-student · Pull Request #54979 · ant-design/ant-design

meet-student · 2025-09-12T11:55:42Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog! Track your changes, like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	Support better customization with semantic classNames/styles as function
🇨🇳 Chinese	Support better customization with semantic classNames/styles as function

bolt-new-by-stackblitz · 2025-09-12T11:55:44Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-09-12T11:55:49Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

Public repositories are always opted into early access features.
You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-09-12T11:55:51Z

👁 Visual Regression Report for PR #54979 Failed ❌

🎯 Target branch: next (38fc1dc)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🆕 3 added

Expected (Branch next)	Actual (Current PR)	Diff
	collapse-style-class.compact.png	🆕🆕🆕 Added 🆕🆕🆕
	collapse-style-class.dark.png	🆕🆕🆕 Added 🆕🆕🆕
	collapse-style-class.default.png	🆕🆕🆕 Added 🆕🆕🆕

Important

There are 3 diffs found in this PR: 🆕 3 added.
Please check all items:

Visual diff is acceptable

github-actions · 2025-09-12T11:55:54Z

gemini-code-assist

Summary of Changes

Hello @meet-student, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the Collapse component's customizability by enabling dynamic application of CSS classes and styles. Developers can now define classNames and styles as functions that receive component props, allowing for more adaptive and context-aware visual adjustments. This enhancement provides a more powerful and flexible way to tailor the component's appearance without altering its core logic.

Highlights

Enhanced Customization for Collapse Component: The Collapse component now supports function-based classNames and styles props, allowing for dynamic application of CSS classes and inline styles based on the component's current properties. This provides greater flexibility for styling and customization.
Integration of useMergeSemantic Hook: The Collapse.tsx file now utilizes the useMergeSemantic hook to intelligently merge context-based and component-specific classNames and styles, ensuring a consistent and extensible styling mechanism.
Updated Type Definitions: New TypeScript types (CollapseSemanticName, CollapseClassNamesType, CollapseStylesType) have been introduced and applied to the CollapseProps interface, reflecting the new function signature for classNames and styles.
New Demo and Documentation: A new demo (style-class.tsx) has been added to showcase both static and function-based styling, accompanied by updated documentation in both English and Chinese (style-class.md, index.en-US.md, index.zh-CN.md) to guide developers on using the new customization options.
Comprehensive Testing: New unit tests in index.test.tsx and updated snapshot tests in demo-extend.test.ts.snap and demo.test.ts.snap ensure the correct functionality and rendering of the new dynamic styling capabilities.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a great enhancement to the Collapse component, allowing classNames and styles to be provided as functions for more dynamic customization. The implementation correctly uses a new useMergeSemantic hook to centralize and simplify the logic for merging styles and classes. The changes are well-tested and include a clear demo. I've found a critical issue with a type rename that will likely break compilation, and a few areas for improvement in the documentation to make the new feature clearer to users.

codecov · 2025-09-12T12:06:56Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (38fc1dc) to head (d68a1d6).
⚠️ Report is 7 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #54979   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          798       798           
  Lines        14727     14729    +2     
  Branches      3896      3896           
=========================================
+ Hits         14727     14729    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pkg-pr-new · 2025-09-21T11:24:09Z

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@54979

commit: d68a1d6

codecov · 2025-09-21T11:24:49Z

Bundle Report

Changes will increase total bundle size by 4.89kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	11.66MB	4.89kB (0.04%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.js`	2.44kB	6.14MB	0.04%
`antd.js`	2.44kB	5.52MB	0.04%

…/styles as function

meet-student · 2025-09-26T14:25:33Z

zombieJ · 2025-09-29T10:02:17Z

+
+import type { CollapseProps } from '..';
+
+const useStyles = createStyles(() => ({


暗色主题得调整一下（或者我们先不要管暗色，语义化结构的demo 加一个强制背景色的配置？）

…/styles as function

…llapse

gemini-code-assist Bot reviewed Sep 12, 2025

View reviewed changes

Comment thread components/collapse/Collapse.tsx

Comment thread components/collapse/demo/style-class.md Outdated

Comment thread components/collapse/index.en-US.md Outdated

Comment thread components/collapse/index.zh-CN.md Outdated

meet-student mentioned this pull request Sep 13, 2025

Support better customization with semantic classNames/styles #54995

Closed

63 tasks done

thinkasany reviewed Sep 21, 2025

View reviewed changes

Comment thread components/collapse/Collapse.tsx

meet-student added 2 commits September 26, 2025 22:06

feat(collapse): Support better customization with semantic classNames…

c9df8ce

…/styles as function

update demo and snap

8f3d943

zombieJ reviewed Sep 29, 2025

View reviewed changes

meet-student and others added 6 commits September 29, 2025 18:55

feat(collapse): Support better customization with semantic classNames…

e797a9c

…/styles as function

update demo and snap

84e66b6

Merge branch 'collapse' of github.com:Meet-student/ant-design into co…

8589a0d

…llapse

chore: update demo

bde9735

Merge branch 'next' into collapse

98c989c

Merge branch 'next' into collapse

d68a1d6

zombieJ approved these changes Sep 30, 2025

View reviewed changes

dosubot Bot added the lgtm This PR has been approved by a maintainer label Sep 30, 2025

zombieJ merged commit 28512dd into ant-design:next Sep 30, 2025
39 checks passed

meet-student deleted the collapse branch October 1, 2025 02:47

zombieJ mentioned this pull request Nov 4, 2025

docs: changelog of 6.0.0-alpha.4 #55604

Merged

1 of 17 tasks


		import type { CollapseProps } from '..';

		const useStyles = createStyles(() => ({

Conversation

meet-student commented Sep 12, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz Bot commented Sep 12, 2025

Uh oh!

coderabbitai Bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

github-actions Bot commented Sep 12, 2025 • edited by zombieJ Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #54979 Failed ❌

Uh oh!

github-actions Bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pkg-pr-new Bot commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

Uh oh!

meet-student commented Sep 26, 2025

Uh oh!

zombieJ Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

meet-student Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Sep 12, 2025 •

edited

Loading

github-actions Bot commented Sep 12, 2025 •

edited by zombieJ

Loading

github-actions Bot commented Sep 12, 2025 •

edited

Loading

codecov Bot commented Sep 12, 2025 •

edited

Loading

pkg-pr-new Bot commented Sep 21, 2025 •

edited

Loading

codecov Bot commented Sep 21, 2025 •

edited

Loading