Skip to content

refactor: semantic of message and notification - #55199

Merged
thinkasany merged 4 commits into
nextfrom
refactor-semantic-hooks
Sep 30, 2025
Merged

thinkasany merged 4 commits into
nextfrom
refactor-semantic-hooks

Conversation

@thinkasany

Copy link
Copy Markdown
Member

🤔 This is a ...

  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English -
🇨🇳 Chinese -

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai

coderabbitai Bot commented Sep 30, 2025 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor-semantic-hooks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Sep 30, 2025 •

Copy link
Copy Markdown
Contributor

Preview failed

@github-actions

github-actions Bot commented Sep 30, 2025 •

Copy link
Copy Markdown
Contributor

👁 Visual Regression Report for PR #55199 Failed ❌

🎯 Target branch: next (8d2e5c4)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 1 changed

Expected (Branch next) Actual (Current PR) Diff
table-sticky.dark.png table-sticky.dark.png table-sticky.dark.png table-sticky.dark.png

Important

There are 1 diffs found in this PR: 🔄 1 changed.
Please check all items:

  • Visual diff is acceptable

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @thinkasany, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the way semantic class names and styles are handled across the message and notification components. It extracts the merging logic into reusable utility functions, mergeClassNames and mergeStyles, which are then consumed by these components. This change aims to centralize common logic, reduce code duplication, and enhance the overall maintainability and consistency of style and class name application within the component library.

Highlights

  • New Utility Functions: Introduced and exported a new mergeStyles utility function within components/_util/hooks/useMergeSemantic/index.ts to centralize style merging logic. It also utilizes mergeClassNames (an existing or newly introduced utility) for class name merging.
  • Refactored Style Merging Logic: The useSemanticStyles hook in components/_util/hooks/useMergeSemantic/index.ts has been updated to leverage the newly exported mergeStyles utility, simplifying its internal implementation.
  • Simplified Component Implementations: The message and notification components (useMessage.tsx and useNotification.tsx) now import and utilize the mergeClassNames and mergeStyles utilities. This replaces their previous manual merging of class names and styles, reducing boilerplate and improving consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the merging of class names and styles in message and notification components by extracting common logic into mergeStyles and utilizing the existing mergeClassNames helper functions. The changes improve code reuse and maintainability. My review includes a suggestion to improve the type safety of the new mergeStyles function.

@github-actions

github-actions Bot commented Sep 30, 2025 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
dist/antd.min.js 496.36 KB (-144 B 🔽)
dist/antd-with-locales.min.js 589.24 KB (-156 B 🔽)

@pkg-pr-new

pkg-pr-new Bot commented Sep 30, 2025 •

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 30, 2025 •

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 7.91MB (-67.8%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.76MB -7.91MB (-67.8%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.min.js (New) 2.07MB 2.07MB 100.0% 🚀
antd.min.js (New) 1.69MB 1.69MB 100.0% 🚀
antd-with-locales.js (Deleted) -6.14MB 0 bytes -100.0% 🗑️
antd.js (Deleted) -5.53MB 0 bytes -100.0% 🗑️

Files in antd-with-locales.min.js:

  • ./components/_util/hooks/useMergeSemantic/index.ts → Total Size: 3.19kB

Files in antd.min.js:

  • ./components/_util/hooks/useMergeSemantic/index.ts → Total Size: 3.19kB

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 30, 2025 •

Copy link
Copy Markdown

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: 136dd0c
Status: ✅  Deploy successful!
Preview URL: https://8f5df839.ant-design.pages.dev
Branch Preview URL: https://refactor-semantic-hooks.ant-design.pages.dev

View logs

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 30, 2025 •

Copy link
Copy Markdown

Deploying ant-design-next with  Cloudflare Pages  Cloudflare Pages

Latest commit: 136dd0c
Status: ✅  Deploy successful!
Preview URL: https://624173fb.ant-design-next.pages.dev
Branch Preview URL: https://refactor-semantic-hooks.ant-design-next.pages.dev

View logs

@codecov

codecov Bot commented Sep 30, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8d2e5c4) to head (136dd0c).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff            @@
##              next    #55199   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          798       798           
  Lines        14747     14747           
  Branches      3897      3896    -1     
=========================================
  Hits         14747     14747           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread components/message/useMessage.tsx Outdated
@@ -219,21 +219,14 @@ export function useInternalMessage(
resolveFunctionStyle(value, config),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有两个可以优化的点:

这个 resolveFunctionStyle 方法没有依赖到组件内部的状态,可以放在外面作为纯函数,另外可以简化一下:

const resolveFunctionStyle = <T extends AnyObject>(
  value: T | ((config: any) => T),
  info: { props: AnyObject },
) => {
  return typeof value === 'function' ? value(info) : value;
};

还有调用的地方没必要用 map,徒增了复杂度,直接用就行:

const semanticClassNames = resolveFunctionStyle(configClassNames, { props: config });

const semanticStyles = resolveFunctionStyle(styles, { props: config });

@thinkasany

Copy link
Copy Markdown
Member Author

bun 又抽了

image

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Sep 30, 2025
@thinkasany
thinkasany merged commit 8a43683 into next Sep 30, 2025
3 of 4 checks passed
@thinkasany
thinkasany deleted the refactor-semantic-hooks branch September 30, 2025 14:49
@zombieJ zombieJ mentioned this pull request Nov 4, 2025
1 of 17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants