Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CollapsePanelProps -> onChange function #7084

Merged
merged 1 commit into from Aug 4, 2017

Conversation

davidctj
Copy link
Contributor

@davidctj davidctj commented Aug 4, 2017

parameter key should be either an array of string(general) or string(accordion mode), right?

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

parameter key should be either an array of string(general) or string(accordion mode), right?
@codecov
Copy link

codecov bot commented Aug 4, 2017

Codecov Report

Merging #7084 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #7084   +/-   ##
======================================
  Coverage    85.8%   85.8%           
======================================
  Files         231     231           
  Lines        4951    4951           
  Branches     1411    1411           
======================================
  Hits         4248    4248           
  Misses        703     703
Impacted Files Coverage Δ
components/collapse/Collapse.tsx 92.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da1403...4369183. Read the comment docs.

@afc163 afc163 merged commit 6e2ace3 into ant-design:master Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants