New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new locale (ar-EG: Arabic Egypt) #3 #7888

Merged
merged 3 commits into from Oct 14, 2017

Conversation

Projects
None yet
2 participants
@mohamed-seada-1994
Contributor

mohamed-seada-1994 commented Oct 13, 2017

This is a pull request for the same changes in #7841 and #7879 , with clean history and no conflict.

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@mohamed-seada-1994

This comment has been minimized.

Contributor

mohamed-seada-1994 commented Oct 13, 2017

I thought the snapshot will be updated if i move the new local to the end of the array, but that does not work.
It seems that the snapshot should be generated with the --updateSnapshot flag.
I have some problems with my environment, so i can't re-generate the snapshot.
Please re-generate it and commit the new one, Thanks!

@afc163 afc163 merged commit fa315e9 into ant-design:antd-3.0 Oct 14, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
security/snyk No new issues
Details

@yesmeck yesmeck referenced this pull request Nov 19, 2017

Closed

Ant Design 3 RC #8233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment