New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select - Moving defaultActiveFirstOption to AbstractSelectProps #8383

Merged
merged 1 commit into from Dec 6, 2017

Conversation

Projects
None yet
2 participants
@nidhi-ag
Contributor

nidhi-ag commented Nov 30, 2017

defaultActiveFirstOption Prop should be exposed to components which are extending AbstractSelectProps, even according the documentation of auto-complete.

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
Select - Moving defaultActiveFirstOption to AbstractSelectProps
defaultActiveFirstOption Prop should be exposed to components which are extending AbstractSelectProps, even according the documentation of auto-complete.

@nidhi-ag nidhi-ag closed this Nov 30, 2017

@nidhi-ag nidhi-ag reopened this Nov 30, 2017

@codecov

This comment has been minimized.

codecov bot commented Nov 30, 2017

Codecov Report

Merging #8383 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8383   +/-   ##
=======================================
  Coverage   83.84%   83.84%           
=======================================
  Files         209      209           
  Lines        4227     4227           
  Branches     1252     1252           
=======================================
  Hits         3544     3544           
  Misses        683      683
Impacted Files Coverage Δ
components/select/index.tsx 97.05% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f37cae...8cea442. Read the comment docs.

@yesmeck

This comment has been minimized.

Member

yesmeck commented Nov 30, 2017

Why move it to AbstractSelectProps ? defaultActiveFirstOption is only used in Select.

@yesmeck yesmeck closed this Dec 3, 2017

@yesmeck yesmeck reopened this Dec 6, 2017

@yesmeck

This comment has been minimized.

Member

yesmeck commented Dec 6, 2017

My fault, it's used in both Select and AutoComplete.

@yesmeck yesmeck merged commit 6d0b488 into ant-design:master Dec 6, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
codecov/patch Coverage not affected when comparing 6f37cae...8cea442
Details
codecov/project 83.84% remains the same compared to 6f37cae
Details
security/snyk No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment