Select - Moving defaultActiveFirstOption to AbstractSelectProps #8383
Conversation
defaultActiveFirstOption Prop should be exposed to components which are extending AbstractSelectProps, even according the documentation of auto-complete.
Codecov Report
@@ Coverage Diff @@
## master #8383 +/- ##
=======================================
Coverage 83.84% 83.84%
=======================================
Files 209 209
Lines 4227 4227
Branches 1252 1252
=======================================
Hits 3544 3544
Misses 683 683
Continue to review full report at Codecov.
|
Why move it to |
My fault, it's used in both Select and AutoComplete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
defaultActiveFirstOption Prop should be exposed to components which are extending AbstractSelectProps, even according the documentation of auto-complete.
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master
, feature for latest active branchfeature-x.x
.npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :