New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style prop for Divider #8504

Merged
merged 1 commit into from Dec 7, 2017

Conversation

Projects
None yet
2 participants
@cyyyu
Contributor

cyyyu commented Dec 7, 2017

Add this for typescript users.


First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@afc163 afc163 merged commit 36831c7 into ant-design:master Dec 7, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
security/snyk No new issues
Details
@afc163

This comment has been minimized.

Member

afc163 commented Dec 7, 2017

Thx!

@codecov

This comment has been minimized.

codecov bot commented Dec 7, 2017

Codecov Report

Merging #8504 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8504   +/-   ##
=======================================
  Coverage   84.96%   84.96%           
=======================================
  Files         226      226           
  Lines        4655     4655           
  Branches     1360     1360           
=======================================
  Hits         3955     3955           
  Misses        700      700
Impacted Files Coverage Δ
components/divider/index.tsx 84.61% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7475f4...a871327. Read the comment docs.

@tastypackets tastypackets referenced this pull request May 21, 2018

Merged

Added missing API documentation #10611

2 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment