New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for disabling arrow icon in collapse panel #8536

Merged
merged 1 commit into from Dec 13, 2017

Conversation

Projects
None yet
2 participants
@apieceofbart
Contributor

apieceofbart commented Dec 10, 2017

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This is in regards to my proposal described here:
#8526

Obviously this requires checking and Chinese translation but I think it's a good starting point.

@apieceofbart apieceofbart referenced this pull request Dec 10, 2017

Closed

Add option for disabling arrow icon in Collapse.Panel #8533

10 of 10 tasks complete
export default class CollapsePanel extends React.Component<CollapsePanelProps, {}> {
render() {
const { prefixCls, className = '', showArrow = true } = this.props;

This comment has been minimized.

@apieceofbart

apieceofbart Dec 10, 2017

Contributor

not sure if all of this is needed

&.@{collapse-prefix-cls}-no-arrow {
> .@{collapse-prefix-cls}-header {
padding-left: 12px;

This comment has been minimized.

@apieceofbart

apieceofbart Dec 10, 2017

Contributor

this is to move the text left so there's no blank space when icon is missing

---
order: 4
title:
zh-CN: TODO

This comment has been minimized.

@apieceofbart

apieceofbart Dec 10, 2017

Contributor

missing translation

## zh-CN
TODO

This comment has been minimized.

@apieceofbart

apieceofbart Dec 10, 2017

Contributor

missing translation

@apieceofbart

This comment has been minimized.

Contributor

apieceofbart commented Dec 11, 2017

tests fail for select component with react 16 - I don't think it's related to my changes

@afc163

This comment has been minimized.

Member

afc163 commented Dec 11, 2017

You can try rebase feature-3.1.

@apieceofbart

This comment has been minimized.

Contributor

apieceofbart commented Dec 11, 2017

hmm I think I'm up to date with feature-3.1..

@afc163

This comment has been minimized.

Member

afc163 commented Dec 11, 2017

Try it again.

@codecov

This comment has been minimized.

codecov bot commented Dec 11, 2017

Codecov Report

Merging #8536 into feature-3.1 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           feature-3.1    #8536      +/-   ##
===============================================
+ Coverage        84.96%   84.98%   +0.01%     
===============================================
  Files              226      227       +1     
  Lines             4657     4661       +4     
  Branches          1360     1361       +1     
===============================================
+ Hits              3957     3961       +4     
  Misses             700      700
Impacted Files Coverage Δ
components/collapse/CollapsePanel.tsx 100% <100%> (ø)
components/collapse/Collapse.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1568c9...298db1f. Read the comment docs.

@apieceofbart

This comment has been minimized.

Contributor

apieceofbart commented Dec 11, 2017

done.

@afc163

This comment has been minimized.

Member

afc163 commented Dec 13, 2017

image

@apieceofbart

This comment has been minimized.

Contributor

apieceofbart commented Dec 13, 2017

@afc163 was that an issue? I added my work email

@afc163 afc163 merged commit 28e9d1e into ant-design:feature-3.1 Dec 13, 2017

4 checks passed

codecov/patch 100% of diff hit (target 84.96%)
Details
codecov/project 84.98% (+0.01%) compared to d1568c9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment