New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ant-spin-container overflow resizing #8602

Merged
merged 1 commit into from Dec 23, 2017

Conversation

Projects
None yet
3 participants
@jhsu
Contributor

jhsu commented Dec 13, 2017

bugfix for the styling on ant-spin-container resizing when adding and removing the ant-spin-blur class to the container.

current:
bug

with the fix:
fixed

tested on several table configurations and on the docs for Spin.

here is a version showing the issue: https://codesandbox.io/s/k2225vk5mo

here is a version with the fix: https://codesandbox.io/s/q3k88zvpy4

@codecov

This comment has been minimized.

codecov bot commented Dec 13, 2017

Codecov Report

Merging #8602 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8602   +/-   ##
=======================================
  Coverage   84.96%   84.96%           
=======================================
  Files         226      226           
  Lines        4657     4657           
  Branches     1360     1360           
=======================================
  Hits         3957     3957           
  Misses        700      700

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9797ac...8d22c5c. Read the comment docs.

@valleykid

This comment has been minimized.

Contributor

valleykid commented Dec 22, 2017

Please give me a demo of the reproduction, Riddle or CodeSandbox. thanks~

@jhsu

This comment has been minimized.

Contributor

jhsu commented Dec 22, 2017

@valleykid I updated the issue with links to examples on codesandbox

@afc163 afc163 merged commit a1fafb5 into ant-design:master Dec 23, 2017

4 checks passed

codecov/patch Coverage not affected when comparing a9797ac...8d22c5c
Details
codecov/project 84.96% remains the same compared to a9797ac
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No new issues
Details

lixiaoyang1992 added a commit to lixiaoyang1992/ant-design that referenced this pull request Jan 3, 2018

lixiaoyang1992 added a commit to lixiaoyang1992/ant-design that referenced this pull request Jan 3, 2018

afc163 added a commit that referenced this pull request Jan 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment