New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rate to 2.4.0 for support allowClear #8627

Merged
merged 1 commit into from Dec 15, 2017

Conversation

Projects
None yet
4 participants
@yutingzhao1991
Contributor

yutingzhao1991 commented Dec 15, 2017

mr for #8539


First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@codecov

This comment has been minimized.

codecov bot commented Dec 15, 2017

Codecov Report

Merging #8627 into feature-3.1 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           feature-3.1    #8627   +/-   ##
============================================
  Coverage        84.98%   84.98%           
============================================
  Files              227      227           
  Lines             4661     4661           
  Branches          1361     1361           
============================================
  Hits              3961     3961           
  Misses             700      700
Impacted Files Coverage Δ
components/rate/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28e9d1e...18f6a4f. Read the comment docs.

@afc163 afc163 merged commit c30ac8d into feature-3.1 Dec 15, 2017

5 checks passed

codecov/patch 100% of diff hit (target 84.98%)
Details
codecov/project 84.98% (+0%) compared to 28e9d1e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details
@@ -16,6 +16,7 @@ Rate component.
| Property | Description | type | Default |
| -------- | ----------- | ---- | ------- |
| allowHalf | whether to allow semi selection | boolean | false |
| allowClear | whether to allow clear when click again | boolean | true |

This comment has been minimized.

@yesmeck

yesmeck Dec 15, 2017

Member

按字母排序

@yesmeck yesmeck deleted the rate-clear branch Dec 15, 2017

@afc163 afc163 referenced this pull request Jun 12, 2018

Closed

Rate can't reset to 0 star #10882

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment