New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

为Tabs增加gutter #8644

Merged
merged 1 commit into from Jan 8, 2018

Conversation

Projects
None yet
2 participants
@lixiaoyang1992
Contributor

lixiaoyang1992 commented Dec 17, 2017

需要rc-tabs更新后配合使用

@@ -38,6 +38,7 @@ Ant Design 依次提供了三级选项卡,分别用于不同的场景。
| onNextClick | next 按钮被点击的回调 | Function | 无 |
| onPrevClick | prev 按钮被点击的回调 | Function | 无 |
| onTabClick | tab 被点击的回调 | Function | 无 |
| gutter | tabs 之间的间隙 | number | 无 |

This comment has been minimized.

@afc163

afc163 Dec 17, 2017

Member

tabBarGutter 更准确点。

@afc163

This comment has been minimized.

Member

afc163 commented Dec 17, 2017

关联 #8456

@lixiaoyang1992 lixiaoyang1992 force-pushed the lixiaoyang1992:tab-pr branch from 25e74ff to ccf21e2 Dec 19, 2017

@yutingzhao1991 yutingzhao1991 changed the base branch from feature-3.1 to feature-3.2 Dec 29, 2017

@afc163

This comment has been minimized.

Member

afc163 commented Jan 1, 2018

rc-tabs@9.2.0 released.

@lixiaoyang1992 lixiaoyang1992 force-pushed the lixiaoyang1992:tab-pr branch 4 times, most recently from 7d60d72 to 0fda365 Jan 3, 2018

@lixiaoyang1992 lixiaoyang1992 force-pushed the lixiaoyang1992:tab-pr branch 2 times, most recently from 0f6974e to 8332d41 Jan 4, 2018

@lixiaoyang1992

This comment has been minimized.

Contributor

lixiaoyang1992 commented Jan 5, 2018

CI里有一个通不过,安装依赖时ETIMEDOUT @afc163

@codecov

This comment has been minimized.

codecov bot commented Jan 5, 2018

Codecov Report

Merging #8644 into feature-3.2 will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           feature-3.2    #8644   +/-   ##
============================================
  Coverage        85.02%   85.02%           
============================================
  Files              227      227           
  Lines             4676     4676           
  Branches          1369     1369           
============================================
  Hits              3976     3976           
  Misses             700      700
Impacted Files Coverage Δ
components/tabs/index.tsx 92% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eff817...8332d41. Read the comment docs.

@afc163 afc163 merged commit 9c52014 into ant-design:feature-3.2 Jan 8, 2018

3 of 4 checks passed

codecov/patch 0% of diff hit (target 85.02%)
Details
codecov/project 85.02% remains the same compared to 1eff817
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment