New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onKeyUp TypeScript definition to Input component #8705

Merged
merged 3 commits into from Dec 28, 2017

Conversation

Projects
None yet
2 participants
@delesseps
Contributor

delesseps commented Dec 22, 2017

Particularly useful if you want to use event.getModifierState('CapsLock') (both onKeyDown and onKeyUp) to show a warning to users when entering passwords etc.

delesseps added some commits Dec 22, 2017

onKeyUp(e);
}
}

This comment has been minimized.

@afc163

afc163 Dec 23, 2017

Member

I don't think handleKeyUp is neccessary, otherProps will handle it.

This comment has been minimized.

@delesseps

delesseps Dec 27, 2017

Contributor

You're right thanks @afc163

@codecov

This comment has been minimized.

codecov bot commented Dec 23, 2017

Codecov Report

Merging #8705 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8705      +/-   ##
==========================================
- Coverage   84.91%   84.86%   -0.06%     
==========================================
  Files         226      226              
  Lines        4666     4670       +4     
  Branches     1363     1364       +1     
==========================================
+ Hits         3962     3963       +1     
- Misses        704      707       +3
Impacted Files Coverage Δ
components/input/Input.tsx 91.93% <100%> (-4.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c6e8e...cec20be. Read the comment docs.

@delesseps delesseps changed the title from Add onKeyUp support to Input component to Add onKeyUp TypeScript definition to Input component Dec 27, 2017

@afc163 afc163 merged commit 8cdf9ea into ant-design:master Dec 28, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
security/snyk No new issues
Details

lixiaoyang1992 added a commit to lixiaoyang1992/ant-design that referenced this pull request Jan 3, 2018

Add onKeyUp TypeScript definition to Input component (ant-design#8705)
* Add onKeyUp support to Input component

* Update snapshot

* Allow other pros to handle onKeyUp

lixiaoyang1992 added a commit to lixiaoyang1992/ant-design that referenced this pull request Jan 3, 2018

Add onKeyUp TypeScript definition to Input component (ant-design#8705)
* Add onKeyUp support to Input component

* Update snapshot

* Allow other pros to handle onKeyUp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment