New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Alert added `iconType` to support custom icon #8811

Merged
merged 1 commit into from Jan 20, 2018

Conversation

Projects
None yet
5 participants
@minwe
Contributor

minwe commented Jan 3, 2018

No description provided.

@codecov

This comment has been minimized.

codecov bot commented Jan 3, 2018

Codecov Report

Merging #8811 into feature-3.2 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           feature-3.2    #8811   +/-   ##
============================================
  Coverage        85.33%   85.33%           
============================================
  Files              227      227           
  Lines             4697     4697           
  Branches          1377     1378    +1     
============================================
  Hits              4008     4008           
  Misses             689      689
Impacted Files Coverage Δ
components/alert/index.tsx 76.74% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa665c...99da0c5. Read the comment docs.

@benjycui

This comment has been minimized.

Contributor

benjycui commented Jan 4, 2018

Please clean your PR, thanks.

@afc163

Mixed up other commits

@yesmeck

This comment has been minimized.

Member

yesmeck commented Jan 13, 2018

Ping @minwe

@minwe

This comment has been minimized.

Contributor

minwe commented Jan 13, 2018

@yesmeck What should I do?

@yesmeck

This comment has been minimized.

Member

yesmeck commented Jan 13, 2018

Clean your commits.

@minwe minwe force-pushed the minwe:master branch from f0d6de8 to 99da0c5 Jan 13, 2018

@minwe

This comment has been minimized.

Contributor

minwe commented Jan 13, 2018

@yesmeck done.

@ddcat1115 ddcat1115 merged commit 7a79330 into ant-design:feature-3.2 Jan 20, 2018

4 checks passed

codecov/patch 100% of diff hit (target 85.33%)
Details
codecov/project 85.33% (+0%) compared to 7aa665c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment