Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Alert added iconType to support custom icon #8811

Merged
merged 1 commit into from Jan 20, 2018

Conversation

minwe
Copy link
Contributor

@minwe minwe commented Jan 3, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jan 3, 2018

Codecov Report

Merging #8811 into feature-3.2 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           feature-3.2    #8811   +/-   ##
============================================
  Coverage        85.33%   85.33%           
============================================
  Files              227      227           
  Lines             4697     4697           
  Branches          1377     1378    +1     
============================================
  Hits              4008     4008           
  Misses             689      689
Impacted Files Coverage Δ
components/alert/index.tsx 76.74% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa665c...99da0c5. Read the comment docs.

@benjycui
Copy link
Contributor

benjycui commented Jan 4, 2018

Please clean your PR, thanks.

Copy link
Member

@afc163 afc163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed up other commits

@yesmeck
Copy link
Member

yesmeck commented Jan 13, 2018

Ping @minwe

@minwe
Copy link
Contributor Author

minwe commented Jan 13, 2018

@yesmeck What should I do?

@yesmeck
Copy link
Member

yesmeck commented Jan 13, 2018

Clean your commits.

@minwe
Copy link
Contributor Author

minwe commented Jan 13, 2018

@yesmeck done.

@ddcat1115 ddcat1115 merged commit 7a79330 into ant-design:feature-3.2 Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants