New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vars for checkbox and radio #9003

Merged
merged 2 commits into from Jan 18, 2018

Conversation

Projects
None yet
2 participants
@mrgeorgegray
Contributor

mrgeorgegray commented Jan 17, 2018

Changes...

  • Adds @checkbox-color var to theme checkboxes
  • Adds @radio-dot-color, @radio-button-color, @radio-button-hover-color and @radio-button-active-color to theme radio buttons

  • feature-3.2.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.
@codecov

This comment has been minimized.

codecov bot commented Jan 17, 2018

Codecov Report

Merging #9003 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9003   +/-   ##
=======================================
  Coverage   85.24%   85.24%           
=======================================
  Files         194      194           
  Lines        4671     4671           
  Branches     1377     1377           
=======================================
  Hits         3982     3982           
  Misses        689      689

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b6d0a...3975958. Read the comment docs.

@afc163 afc163 merged commit a9abe14 into ant-design:master Jan 18, 2018

4 checks passed

codecov/patch Coverage not affected when comparing a2b6d0a...3975958
Details
codecov/project 85.24% remains the same compared to a2b6d0a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No new issues
Details

@mrgeorgegray mrgeorgegray deleted the mrgeorgegray:vars-for-checkbox-and-radio branch Jan 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment